Remove BankQuery::AllBalances and query_all_balances #2433
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 24, 2025
webmaster128
force-pushed
the
all-balances
branch
from
21a6c42 to
c7fb0a2
Compare
webmaster128
force-pushed
the
all-balances
branch
2 times, most recently
from
f10d040 to
8bdaf98
Compare
webmaster128
force-pushed
the
all-balances
branch
from
8bdaf98 to
2ff3b11
Compare
webmaster128
force-pushed
the
all-balances
branch
from
2ff3b11 to
dd69623
Compare
chipshort
approved these changes
Apr 23, 2025
Comment on lines
-917
to
+922
| assert_eq!(report2.used_internally, 24140405); | ||
| assert_eq!(report2.used_internally, 17646125); |
There was a problem hiding this comment.
Oh, nice. The optimizer upgrade makes quite a difference
There was a problem hiding this comment.
Yeah. But this is also due to an upgrade to latest cosmwasm-std, which changes the JSON serde library
There was a problem hiding this comment.
Ah, true. I forgot about that one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2252